Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multi-tenant queries #3087

Merged
merged 34 commits into from
Dec 18, 2023

Conversation

electron0zero
Copy link
Member

@electron0zero electron0zero commented Oct 30, 2023

What this PR does:

Add multi-tenant query support in selected routes:

  • TraceByID
  • Search
  • SearchTags
  • SearchTagsV2
  • SearchTagsValues
  • SearchTagsValuesV2

Note: SpanMetricsSummary and Streaming Search endpoints does not support multi-tenant queries.

Which issue(s) this PR fixes:
Fixes #1858

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@knylander-grafana
Copy link
Contributor

@electron0zero We have some doc for multi-tenant stuff in GET, if this is similar to federation frontend and cross-tenant query. Happy to point you to that content. We just updated it.

integration/e2e/multi_tenant_test.go Show resolved Hide resolved
integration/e2e/multi_tenant_test.go Outdated Show resolved Hide resolved
integration/e2e/multi_tenant_test.go Outdated Show resolved Hide resolved
modules/frontend/combiner/interface.go Outdated Show resolved Hide resolved
modules/frontend/combiner/search.go Outdated Show resolved Hide resolved
modules/frontend/combiner/search.go Show resolved Hide resolved
modules/frontend/tenant.go Outdated Show resolved Hide resolved
modules/frontend/tenant.go Show resolved Hide resolved
@electron0zero
Copy link
Member Author

@electron0zero We have some doc for multi-tenant stuff in GET, if this is similar to federation frontend and cross-tenant query. Happy to point you to that content. We just updated it.

@knylander-grafana added docs https://github.com/grafana/tempo/pull/3087/files?short_path=9270c41#diff-9270c41ebeff244ecbc46a0d2f63bbe0e11cc7f4a06c13511e7e71d49c29bade

Co-authored-by: Kim Nylander <104772500+knylander-grafana@users.noreply.github.com>
Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the doc. Thank you for adding this!

@mdisibio mdisibio merged commit 0fc6bf1 into grafana:main Dec 18, 2023
15 checks passed
@electron0zero electron0zero deleted the add_federation branch January 9, 2024 15:25
@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Jan 23, 2024
electron0zero added a commit that referenced this pull request Jan 25, 2024
Add multi-tenant query support in streaming search endpoints.

follow up on #3087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ability to search all tenants in multi-tenant setups
4 participants