Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-2605: Make span.resource.xyz attributes work #3284

Merged
merged 2 commits into from Jan 17, 2024

Conversation

mghildiy
Copy link
Contributor

@mghildiy mghildiy commented Jan 11, 2024

Solves the error when searching for span attributes that start with resource.:

Which issue(s) this PR fixes:
Fixes #2605

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Made a suggestion for clarity in the changelog but otherwise lgtm.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Elliott <joe.elliott@grafana.com>
@joe-elliott joe-elliott merged commit d457633 into grafana:main Jan 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TraceQL: Error when searching for span attributes that start with resource.
2 participants