Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precalculate and reuse the vParquet3 schema before opening blocks #3367

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

stoewer
Copy link
Collaborator

@stoewer stoewer commented Feb 6, 2024

What this PR does:

Precalculate and reuse the vParquet3 schema. This performance optimization saves a small amount of CPU time when blocks are opened for search

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@stoewer stoewer changed the title vParquet3: calculate the parquet schema only once Precalculate and reuse the vParquet3 schema before opening blocks Feb 6, 2024
This saves a small amount of CPU time when blocks are opened
@stoewer stoewer force-pushed the calculate-parquet-schema-once branch from 4bf27dc to acbc7e4 Compare February 6, 2024 00:34
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoewer stoewer merged commit 5b739f8 into grafana:main Feb 6, 2024
14 checks passed
@stoewer stoewer deleted the calculate-parquet-schema-once branch February 6, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants