Fix trace context propagation in the read path #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mapno
force-pushed
the
fix-read-path-tracing
branch
from
2ac5766
to
09bd981
Compare
mdisibio
approved these changes
Feb 13, 2024
kvrhdn
pushed a commit
to kvrhdn/tempo
that referenced
this pull request
Feb 26, 2024
* Correctly propagate trace context between query-frontend and querier * Add tracing to distributed docker-compose example * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes trace context propagation between query-frontend and querier. The context was not being correctly passed and unpacked between both.
It also adds tracing to the distributed docker-compose example.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]