Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Cortex version #341

Merged
merged 3 commits into from
Nov 13, 2020
Merged

Bump Cortex version #341

merged 3 commits into from
Nov 13, 2020

Conversation

dgzlopes
Copy link
Member

@dgzlopes dgzlopes commented Nov 13, 2020

What this PR does:
This PR bumps Cortex version. From v1.3.0 to v1.4.0.

I followed Tempo docs on how to do dependency management.

Which issue(s) this PR fixes:
Related #337

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
@dgzlopes dgzlopes marked this pull request as ready for review November 13, 2020 17:06
@dgzlopes dgzlopes changed the title [WIP] Bump Cortex version Bump Cortex version Nov 13, 2020
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have extensively reviewed every line of all 770 files changed and fully endorse each change.

LGTM :P

@joe-elliott joe-elliott merged commit 1e492cb into grafana:master Nov 13, 2020
@dgzlopes dgzlopes deleted the bump-cortex branch November 13, 2020 20:45
@dgzlopes
Copy link
Member Author

Next time I'll create multiple PRs. One for each 10K lines 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants