feat: add option to S3 backend for V2 signatures #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mdisibio
reviewed
Nov 19, 2020
joe-elliott
reviewed
Nov 19, 2020
simonswine
force-pushed
the
add-v2-signatures-option
branch
2 times, most recently
from
5bb63c2
to
8a15717
Compare
Currently we don't expose any ability to select the signature version used for our S3 backend. Signed-off-by: Christian Simon <simon@swine.de>
simonswine
force-pushed
the
add-v2-signatures-option
branch
from
8a15717
to
b9a84e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a config option/flag to use signature version 2 in the S3 backend. This will switch from the default V4 auth to a V2, which might be necessary for some object storage implementations.
Which issue(s) this PR fixes:
Fixes #<issue number
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]