Add querier metrics for requests executed #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
zalegrala,
ie-pham and
stoewer
as code owners
electron0zero
changed the title
joe-elliott
reviewed
Mar 27, 2024
| @@ -27,6 +29,12 @@ var processorBackoffConfig = backoff.Config{ | |||
| MaxBackoff: 1 * time.Second, | |||
| } | |||
|
|
|||
| var metricWorkerRequests = promauto.NewCounter(prometheus.CounterOpts{ | |||
There was a problem hiding this comment.
i don't mind this but do you expect it to be significantly different than the querier request rates?
There was a problem hiding this comment.
yup, I think request rate is for batches, and this is at job level (single request). we can rate the counter to capture how much work each querier is doing...
electron0zero
changed the title
joe-elliott
approved these changes
Mar 27, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds two metrics to provide observability into read path and query processing
tempo_querier_worker_request_executed_totalis a counter, measuring the requests executed by the querierWhich issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]