Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ops] Fix resources dashboard, disable tempo-query tracing by default #353

Merged
merged 2 commits into from Nov 19, 2020

Conversation

annanay25
Copy link
Contributor

Signed-off-by: Annanay annanayagarwal@gmail.com

What this PR does:
Minor improvements to tempo operational tools

  • add resources panel for tempo distributor
  • disable tracing on the tempo-query container using JAEGER_DISABLED=true

Which issue(s) this PR fixes:
Fixes #

Checklist

  • NA Tests updated
  • NA Documentation added
  • NA CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Annanay <annanayagarwal@gmail.com>
@annanay25
Copy link
Contributor Author

cc @bombsimon

@annanay25
Copy link
Contributor Author

Please hold on this PR. I'm getting a crashloop on the jaeger-query, checking again.

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Copy link
Contributor

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! LGTM!

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

thx for the research and review @bombsimon

@joe-elliott joe-elliott merged commit 2b34ea3 into grafana:master Nov 19, 2020
@annanay25 annanay25 deleted the resources-dash branch November 19, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants