Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os path separator to split blocks path #3568

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

teyyubismayil
Copy link
Contributor

@teyyubismayil teyyubismayil commented Apr 12, 2024

What this PR does:
Use os path separator to split blocks path so local backend works also on Windows

Which issue(s) this PR fixes:
Fixes #3552

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Can you add a changelog entry?

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it obvious we don't have a lot of folks running Tempo on windows? :)

Great fix. Thanks for the contribution!

@joe-elliott joe-elliott merged commit f9b37a8 into grafana:main Apr 12, 2024
14 checks passed
@teyyubismayil teyyubismayil deleted the backend-path-separator branch April 12, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traces are not available after 30 minutes on Windows
2 participants