Update docker compose examples #3603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
kvrhdn,
electron0zero,
ie-pham and
stoewer
as code owners
* Drop deprecated `version` field * Add init service to chown the volume on startup and set dependency for ordered startup * Use yaml reference for docker image specification
zalegrala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we udpate the docker compose examples, and remove a few which we have coverage for in the integration and in our docs.
Include init service to chown the local data. This was required after the
UID change and doing this with a container matches both the jsonnet, and the
intended appraoach we take to helm.
Delete the s3/gcs/azure examples. The integration tests cover these cases.
The existing distributed example has an s3 backened example.
Delete the grafana7.4 example. This is old and newer grafana versions are recommended.
Update docs to reflect the changes.
Related: #3601
Related: #2265
Related: #3596
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]