Change to TOC structure and other reorg to individual topics #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achatterjee-grafana
requested review from
annanay25 and
joe-elliott
as code owners
|
|
joe-elliott
approved these changes
Nov 24, 2020
joe-elliott
deleted the
Change-to-TOC-structure-and-other-reorg-to-individual-topics
branch
annanay25
reviewed
Nov 24, 2020
There was a problem hiding this comment.
Thanks @achatterjee-grafana!
One more thing, can we remove the .DS_Store files from the repo as part of a future PR?
|
|
||
| ### Spin up Tempo backend | ||
| > **Note:** The Grafana Cloud Agent is already set up to use Tempo. Refer to the [configuration](https://github.com/grafana/agent/blob/master/docs/configuration-reference.md#tempo_config) and [example](https://github.com/grafana/agent/blob/master/example/docker-compose/agent/config/agent.yaml) for details. | ||
| ### Step 1: Spin up Tempo backend |
There was a problem hiding this comment.
nit: This needs to be a ## to match the header size with other steps
|
|
||
| ## Setting up Tempo | ||
| Getting started with Tempo is easy. For an application already instrumented for tracing, this guide can help quickly set it up with Tempo. If you're looking for a demo application to play around with Tempo, skip to the [examples with demo app]({{< relref "example-demo-app.md" >}})topic. |
There was a problem hiding this comment.
nit: We need a space between the link and the following word here - [examples with demo app]({{< relref "example-demo-app.md" >}})topic
There was a problem hiding this comment.
@joe-elliott, did you fix the nits @annanay25 pointed out? LMK, thanks!
There was a problem hiding this comment.
@achatterjee-grafana i did not. merged blindly!
feel free to submit a new PR :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to TOC and general restructuring based on #356.