Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore metrics and query-frontend call for latency alert. #440

Merged
merged 2 commits into from
Jan 6, 2021

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Jan 6, 2021

What this PR does: This PR ignores some routes when checking for TempoRequestLatency alert. Specifically query-frontend route is designed to be called as long-running request, so we should ignore it.

Checklist

  • [NA] Tests updated
  • [NA] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pstibrany!

@annanay25 annanay25 merged commit e804efd into master Jan 6, 2021
@annanay25 annanay25 deleted the ignore-routes-when-computing-request-latency branch January 6, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants