Refactor cache section in tempodb/backend #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
dgzlopes
requested review from
achatterjee-grafana,
annanay25,
joe-elliott and
mdisibio
as code owners
dgzlopes
changed the title
annanay25
reviewed
Feb 2, 2021
annanay25
approved these changes
Feb 2, 2021
joe-elliott
approved these changes
Feb 2, 2021
There was a problem hiding this comment.
I'll @annanay25 land the final approval and merge since he's spent more time with it, but overall excellent work. I had been frustrated with the organization of the backend for awhile and this PR is going a long way to bringing it to where I want it.
One nit, but otherwise LGTM.
Great work @dgzlopes.
dgzlopes
force-pushed
the
refactor/cache-tempodb
branch
from
16482f3
to
5fb82ce
Compare
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
dgzlopes
force-pushed
the
refactor/cache-tempodb
branch
from
5fb82ce
to
e73c89b
Compare
|
Thanks @dgzlopes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened in favor of #399
What this PR does:
tempodb./operationsconfigs.Which issue(s) this PR fixes:
Fixes #373
Fixes #372
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]