Add new compaction max_block_bytes setting
#520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
achatterjee-grafana,
annanay25 and
joe-elliott
as code owners
joe-elliott
reviewed
Feb 10, 2021
mdisibio
changed the title
max_block_size settingmax_block_bytes setting
joe-elliott
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR starts the transition moving away from the trace-oriented
max_compaction_objectssetting to a data-orientedmax_block_bytessetting. TimeWindowBlockSelector enforces this limit by simply summing the block data sizes added in #515 which is an estimate but accurate enough. For compatibility,max_compaction_objectsremains as existing blocks may not yet have the new Size, but is deprecated and removed from examples.Additionally, the TimeWindowBlockSelector was refactored to a (hopefully) simpler design that will accommodate more changes to compaction behavior in the future.
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]