Add HTTP endpoint /api/echo to query-frontend #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvrhdn
requested review from
annanay25,
dgzlopes,
joe-elliott and
mdisibio
as code owners
joe-elliott
reviewed
May 28, 2021
joe-elliott
reviewed
May 28, 2021
cmd/tempo/app/modules.go
Outdated
| @@ -274,3 +276,13 @@ func (t *App) setupModuleManager() error { | |||
| func queryEndpoint(cfg *Config) string { | |||
| return cfg.HTTPAPIPrefix + "/api/traces/{traceID}" | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Let me nit you just a bit more :)!
let's make a single method with some really basic tests:
func applyHTTPPrefix(cfg, path) {
}
Also let's use path.Join instead of string concat.
Thanks for the work, we're almost there!
There was a problem hiding this comment.
Done! I didn't add a unit test for addHTTPAPIPrefix because the function is really small and not very error-prone (feel free to disagree on this!).
If we change this logic at some point, the e2e tests should break.
I did notice whoever that the e2e tests don't configure a prefix... What do you think, should I adapt one of the configs to use a prefix?
The echo endpoint can be used by Grafana to test Tempo whether is reachable. grafana#624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds a new endpoint
/api/echothat always returns with 200 and a bodyecho.Which issue(s) this PR fixes:
Closes #624
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]