Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e integrations test for GCS #883

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

annanay25
Copy link
Contributor

Fixes #817. Follow up of #879

Checklist

  • Tests updated
  • NA Documentation added
  • NA CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Annanay annanayagarwal@gmail.com

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Copy link
Member

@kvrhdn kvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM 🙂

integration/util.go Show resolved Hide resolved
@annanay25 annanay25 merged commit e2c6872 into grafana:main Aug 17, 2021
@annanay25 annanay25 deleted the e2e-gcs branch August 17, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: e2e test for GCS
2 participants