Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Vulture for query verification #904

Merged
merged 14 commits into from Sep 2, 2021
Merged

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Aug 23, 2021

This chance modifies the randomization to allow for the query response attributes to be verified against the deterministic pseudo-random attribute generation.

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
@zalegrala zalegrala force-pushed the vultureTest branch 6 times, most recently from 96a27a2 to f67409c Compare August 26, 2021 21:31
@zalegrala zalegrala marked this pull request as ready for review August 26, 2021 21:31
@zalegrala zalegrala force-pushed the vultureTest branch 3 times, most recently from 362569d to 1a26285 Compare August 27, 2021 17:03
cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
cmd/tempo-vulture/main.go Outdated Show resolved Hide resolved
@zalegrala zalegrala force-pushed the vultureTest branch 5 times, most recently from 1b75e4a to f1a2d56 Compare September 1, 2021 17:16
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mdisibio mdisibio merged commit bfa22b7 into grafana:main Sep 2, 2021
@zalegrala zalegrala deleted the vultureTest branch September 2, 2021 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants