-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add status endpoint to list the available endpoints #938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work.
Even though I feel the addition of api docs (https://grafana.com/docs/tempo/latest/api_docs/) has depreciated this endpoint, its still nice to have. Some nits:
- Can we add a "table header"? It might be confusing to just see the regex
- Can we add a line at the end pointing to the api docs for further info?
Should we call this Possibly even support some basic arguments (otherwise dump everything): |
Great suggestions, thanks for the review. Do we want a table printed here, or something machine consumable. I feel like if I were to call something on |
06cb79f
to
5108e27
Compare
5108e27
to
35200e8
Compare
I've made some updates here and set us up to add more query params later on a |
I'll update the docs page too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added doc review.
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
7bcf44b
to
3dc2d0e
Compare
Here we include an
/admin
endpoint that will print all the available endpoints and the regex that will route to the endpoint.Which issue(s) this PR fixes:
Fixes #632
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]