Cloud Stack: More reliable retrying #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #996 There have been reliability issues with stacks related to Terraform Grafana.com has a very asynchronous process that works well in the web but not so much in Terraform While an API 500 in the web UI is not that annoying, since the stack shows up on the next refresh, it disrupts Terraform In this PR, I make the stack creation process retry on pretty much every error To test that everything works well, I added two test cases: - Tainting a stack to test that it can recreate right after deletion - Creating a stack in double, making sure we can't take-over a stack that already exists
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
inkel
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #996
There have been reliability issues with stacks related to Terraform
Grafana.com has an asynchronous process that works well in the web but not so much in Terraform: While an API 500 in the web UI is not that annoying, since the stack shows up on the next refresh, it disrupts Terraform
In this PR, I make the stack creation process retry on pretty much every error
To test that everything works well, I added two test cases: