Add Library Panel Resource #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
justinTM
force-pushed
the
Library-Elements
branch
from
34c78e0
to
9deeaf1
Compare
justinTM
force-pushed
the
Library-Elements
branch
from
9deeaf1
to
de9eb02
Compare
justinTM
force-pushed
the
Library-Elements
branch
from
1d15390
to
ef5efb2
Compare
|
@julienduchesne should i remove the |
Didn't realize that this was ready to test due to the failing tests (not your fault, library panels don't exist in v7). I can take a look tomorrow. I'll probably push something to your branch to ignore this resource on the v7 tests To answer your question, after is fine. When I approve this PR, I'll merge the client and then we can update this PR and merge it too |
julienduchesne
added a commit
that referenced
this pull request
Jan 31, 2022
Will be used for library panels: #331. This is a feature from v8 so the tests on v7 shouldn't run This line can be added to the test: `CheckOSSTestsSemver(t, ">=8.0.0")` If a feature is deprecated from Grafana in the future, we can add a lower than semver
julienduchesne
added a commit
that referenced
this pull request
Jan 31, 2022
Will be used for library panels: #331. This is a feature from v8 so the tests on v7 shouldn't run This line can be added to the test: `CheckOSSTestsSemver(t, ">=8.0.0")` If a feature is deprecated from Grafana in the future, we can add a lower than semver
julienduchesne
added a commit
that referenced
this pull request
Jan 31, 2022
Will be used for library panels: #331. This is a feature from v8 so the tests on v7 shouldn't run This line can be added to the test: `CheckOSSTestsSemver(t, ">=8.0.0")` If a feature is deprecated from Grafana in the future, we can add a lower than semver
julienduchesne
added a commit
that referenced
this pull request
Jan 31, 2022
Will be used for library panels: #331. This is a feature from v8 so the tests on v7 shouldn't run This line can be added to the test: `CheckOSSTestsSemver(t, ">=8.0.0")` If a feature is deprecated from Grafana in the future, we can add a lower than semver
julienduchesne
added a commit
that referenced
this pull request
Jan 31, 2022
* Add function to check semver for OSS tests Will be used for library panels: #331. This is a feature from v8 so the tests on v7 shouldn't run This line can be added to the test: `CheckOSSTestsSemver(t, ">=8.0.0")` If a feature is deprecated from Grafana in the future, we can add a lower than semver * Remove test check
Co-authored-by: Julien Duchesne <julienduchesne@live.com>
…ider-grafana into Library-Elements
Co-authored-by: Julien Duchesne <julienduchesne@live.com>
…ider-grafana into Library-Elements
|
@julienduchesne good to go! Thank you for your review |
julienduchesne
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be my first substantial Go code, and it also relies on some yet-nonexistent grafana go API additions for library panels