Add function to check semver for OSS tests #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienduchesne
force-pushed
the
julienduchesne/add-semver-check
branch
2 times, most recently
from
017970a
to
218df89
Compare
Will be used for library panels: #331. This is a feature from v8 so the tests on v7 shouldn't run This line can be added to the test: `CheckOSSTestsSemver(t, ">=8.0.0")` If a feature is deprecated from Grafana in the future, we can add a lower than semver
julienduchesne
force-pushed
the
julienduchesne/add-semver-check
branch
from
218df89
to
31f5ef4
Compare
|
If you go into the first commit build: https://drone.grafana.net/grafana/terraform-provider-grafana/558, you can see that I skipped a test for v7 |
inkel
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used for library panels: #331. This is a feature from v8 so the tests on v7 shouldn't run
This line can be added to the test:
CheckOSSTestsSemver(t, ">=8.0.0")If a feature is deprecated from Grafana in the future, we can add a lower than semver