Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New data_source_role resource #917

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

skatsaounis
Copy link
Contributor

@skatsaounis skatsaounis commented May 16, 2023

Adds new data_source_role resource which fetches RBAC roles by name.

It can solve #700 as well.

Relevant Go Client PR: grafana/grafana-api-golang-client#151

@skatsaounis skatsaounis requested a review from a team as a code owner May 16, 2023 07:12
@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

go.sum Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@skatsaounis
Copy link
Contributor Author

@inkel I update the PR with the new client version and it is ready to be reviewed.

Copy link
Contributor

@inkel inkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing because it's missing the go.sum updated entry for the Grafana Go client. By looking at the list of changed files it seems you forgot to include it in your last commit, please add it and I'll happily review the PR.

@skatsaounis
Copy link
Contributor Author

@inkel I think we are good to go now. I tried to rebase and fix conflicts and somehow I messed up go.sum. Please take a look

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julienduchesne julienduchesne merged commit 335b322 into grafana:master Jul 5, 2023
2 of 3 checks passed
@skatsaounis skatsaounis deleted the add-datasource-role branch July 5, 2023 08:55
github-merge-queue bot pushed a commit to panda-den/colorful-pandas that referenced this pull request Jul 6, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [grafana](https://registry.terraform.io/providers/grafana/grafana)
([source](https://togithub.com/grafana/terraform-provider-grafana)) |
required_provider | minor | `1.42.0` -> `1.43.0` |

---

### Release Notes

<details>
<summary>grafana/terraform-provider-grafana (grafana)</summary>

###
[`v1.43.0`](https://togithub.com/grafana/terraform-provider-grafana/releases/tag/v1.43.0)

[Compare
Source](https://togithub.com/grafana/terraform-provider-grafana/compare/v1.42.0...v1.43.0)

#### What's Changed

- Additional information on annotations and labels for the SLO provider
by [@&#8203;Leo-DiCara](https://togithub.com/Leo-DiCara) in
[grafana/terraform-provider-grafana#952
- Add Grafana 10 to tested versions by
[@&#8203;julienduchesne](https://togithub.com/julienduchesne) in
[grafana/terraform-provider-grafana#956
- Alerting Rule Group: Allow days in validation by
[@&#8203;julienduchesne](https://togithub.com/julienduchesne) in
[grafana/terraform-provider-grafana#959
- Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.26.1 to
2.27.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[grafana/terraform-provider-grafana#961
- New `data_source_role` resource by
[@&#8203;skatsaounis](https://togithub.com/skatsaounis) in
[grafana/terraform-provider-grafana#917

#### New Contributors

- [@&#8203;Leo-DiCara](https://togithub.com/Leo-DiCara) made their first
contribution in
[grafana/terraform-provider-grafana#952

**Full Changelog**:
grafana/terraform-provider-grafana@v1.42.0...v1.43.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xLjgiLCJ1cGRhdGVkSW5WZXIiOiIzNi4xLjgiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=-->

Co-authored-by: astronaut-panda[bot] <137164246+astronaut-panda[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants