-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data_source_role
resource
#917
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
4306676
to
906c202
Compare
6a43508
to
5a67443
Compare
@inkel I update the PR with the new client version and it is ready to be reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing because it's missing the go.sum
updated entry for the Grafana Go client. By looking at the list of changed files it seems you forgot to include it in your last commit, please add it and I'll happily review the PR.
5a67443
to
2792528
Compare
@inkel I think we are good to go now. I tried to rebase and fix conflicts and somehow I messed up |
2792528
to
cb5db71
Compare
cb5db71
to
0b2398c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [grafana](https://registry.terraform.io/providers/grafana/grafana) ([source](https://togithub.com/grafana/terraform-provider-grafana)) | required_provider | minor | `1.42.0` -> `1.43.0` | --- ### Release Notes <details> <summary>grafana/terraform-provider-grafana (grafana)</summary> ### [`v1.43.0`](https://togithub.com/grafana/terraform-provider-grafana/releases/tag/v1.43.0) [Compare Source](https://togithub.com/grafana/terraform-provider-grafana/compare/v1.42.0...v1.43.0) #### What's Changed - Additional information on annotations and labels for the SLO provider by [@​Leo-DiCara](https://togithub.com/Leo-DiCara) in [grafana/terraform-provider-grafana#952 - Add Grafana 10 to tested versions by [@​julienduchesne](https://togithub.com/julienduchesne) in [grafana/terraform-provider-grafana#956 - Alerting Rule Group: Allow days in validation by [@​julienduchesne](https://togithub.com/julienduchesne) in [grafana/terraform-provider-grafana#959 - Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.26.1 to 2.27.0 by [@​dependabot](https://togithub.com/dependabot) in [grafana/terraform-provider-grafana#961 - New `data_source_role` resource by [@​skatsaounis](https://togithub.com/skatsaounis) in [grafana/terraform-provider-grafana#917 #### New Contributors - [@​Leo-DiCara](https://togithub.com/Leo-DiCara) made their first contribution in [grafana/terraform-provider-grafana#952 **Full Changelog**: grafana/terraform-provider-grafana@v1.42.0...v1.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xLjgiLCJ1cGRhdGVkSW5WZXIiOiIzNi4xLjgiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: astronaut-panda[bot] <137164246+astronaut-panda[bot]@users.noreply.github.com>
Adds new
data_source_role
resource which fetches RBAC roles by name.It can solve #700 as well.
Relevant Go Client PR: grafana/grafana-api-golang-client#151