Alerting Rule Group: Allow days in validation #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
inkel
approved these changes
Jun 29, 2023
github-merge-queue bot
pushed a commit
to panda-den/colorful-pandas
that referenced
this pull request
Jul 6, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [grafana](https://registry.terraform.io/providers/grafana/grafana) ([source](https://togithub.com/grafana/terraform-provider-grafana)) | required_provider | minor | `1.42.0` -> `1.43.0` | --- ### Release Notes <details> <summary>grafana/terraform-provider-grafana (grafana)</summary> ### [`v1.43.0`](https://togithub.com/grafana/terraform-provider-grafana/releases/tag/v1.43.0) [Compare Source](https://togithub.com/grafana/terraform-provider-grafana/compare/v1.42.0...v1.43.0) #### What's Changed - Additional information on annotations and labels for the SLO provider by [@​Leo-DiCara](https://togithub.com/Leo-DiCara) in [grafana/terraform-provider-grafana#952 - Add Grafana 10 to tested versions by [@​julienduchesne](https://togithub.com/julienduchesne) in [grafana/terraform-provider-grafana#956 - Alerting Rule Group: Allow days in validation by [@​julienduchesne](https://togithub.com/julienduchesne) in [grafana/terraform-provider-grafana#959 - Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.26.1 to 2.27.0 by [@​dependabot](https://togithub.com/dependabot) in [grafana/terraform-provider-grafana#961 - New `data_source_role` resource by [@​skatsaounis](https://togithub.com/skatsaounis) in [grafana/terraform-provider-grafana#917 #### New Contributors - [@​Leo-DiCara](https://togithub.com/Leo-DiCara) made their first contribution in [grafana/terraform-provider-grafana#952 **Full Changelog**: grafana/terraform-provider-grafana@v1.42.0...v1.43.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xLjgiLCJ1cGRhdGVkSW5WZXIiOiIzNi4xLjgiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: astronaut-panda[bot] <137164246+astronaut-panda[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in #941
Closes #955
Turns out the duration lib used in alerting supports days and weeks. Let's use the same lib here