cli: Make loaders work independent of disk state #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildwonkey
pushed a commit
that referenced
this pull request
May 1, 2023
cli: Make loaders work independent of disk state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was just a horrifying situation. This should just about do it - though in a follow-up, i'll need to make Go bindings generators aware of the new improvements and generate smarter
embed.FSdeclarations.Unfortunately, this doesn't do anything really reusable with the
loadpackage. Turns out, sensitivity to cwd makes the CLI case really different from the "run the binary anywhere" case. Or at least, it's seemed to so far, enough to discourage reuse.Fixes #79