-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change timestamp fieldType to be nullable #184
Conversation
Since datumParserTimestamp can return nil value, fieldType also should allow nil. Without this, nil timestamp will be recognized as a strange timestamp, such as 1754-08-30 22:43:41 UTC (-6795364578871). Follow-up: 4750ff8
|
@nekketsuuu I have now re-generated the test files for you. Sorry it's been taking such a long time. Let us know when this PR is ready for review and we'll take a look. Thanks! |
@sunker Awesome! Thank you for looking my pull request! I checked your changes and marked this pull request is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for contributing @nekketsuuu!
#162
Since
datumParserTimestamp
can return nil value,fieldType
also should allow nil.Without this, nil timestamp will be recognized as a strange timestamp, such as 1754-08-30 UTC (-6795364578871).
Follow-up: 4750ff8
Screenshots
The second record contains a null value in
clock
measure, which is displayed as 1754-08-31 in the first screenshot and as an empty cell in the second screenshot.How to reproduce these screenshots
select * from $__database.$__table where $__timeFilter
.Tests
Currently I marked this pull request as draft because I couldn't update test files. It's difficult to me to update them for a reason described by #183. I'd appreciate if someone would tell me how to regenerate golden files from scratch.Solved by 9e24fb7