Add contributing guideline #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend code coverage report for PR #192 |
|
Frontend code coverage report for PR #192 |
iwysiu
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
lgtm with one fix.
Also we can add the development with local grafana section from redshift if we think it'll be useful.
fridgepoet
reviewed
Sep 23, 2022
Comment on lines
-19
to
-22
| 1. (Optional) `mage -v buildAll` — this is optional if you need backend plugins for other platforms | ||
| 1. The compiled plugin should be in `dist/` directory. | ||
| 1. Run Grafana in [development](https://grafana.com/docs/grafana/latest/administration/configuration/#app_mode) mode, or configure Grafana to [load the unsigned plugin](https://grafana.com/docs/grafana/latest/plugins/plugin-signatures/#allow-unsigned-plugins). | ||
| 1. You can install by following the [install Grafana plugins docs page](https://grafana.com/docs/grafana/latest/plugins/installation/). |
There was a problem hiding this comment.
This information will be removed by your changes. Is that intentional?
There was a problem hiding this comment.
Yes, we (this was done in a mob session last week) were trying to streamline the readme with the other plugins we have.
fridgepoet
approved these changes
Sep 23, 2022
sunker
force-pushed
the
golden-files-docs
branch
from
ea12f26
to
57b88cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a contributing guideline with details about how to generate the golden files.
Related to #184
Fixes #183
cc @nekketsuuu