Add cloud-specific deployment and configuration #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @eamonryan |
56quarters
approved these changes
May 6, 2022
install
Outdated
| @@ -12,7 +13,7 @@ function install_env { | |||
| tk apply environments/$ENV # Installs everything for your environment. | |||
| } | |||
|
|
|||
| if [[ $(docker info --format "{{.MemTotal}}") -lt 2560000000 ]]; then | |||
| if [[ "$MODE" != "cloud" ]] && [[ $(docker info --format "{{.MemTotal}}") -lt 2560000000 ]]; then | |||
There was a problem hiding this comment.
Could you add a note to the README (wherever it makes sense) that this is an option?
There was a problem hiding this comment.
I realize this is for Grafana Cloud but there doesn't seem to be anything cloud-specific about this. Maybe a different name like "app-only" or "existing" or something like that? (please feel free to pick something better than my suggestions)
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to deploy the TNS app and mixin when using our cloud products & Kubernetes integration.
There will be an accompanying doc in Cloud docs that will walk the user through deploying the app, deploying the mixin (using Grizzly), and navigating the dashboards.
Existing code paths are mostly unchanged.
This PR does the following:
cloudparameter, installs only the TNS app into an existing K8s cluster, without Loki, Grafana, Agent, etc.clouddeployment path, patches the app to use a slightly different Jaeger config (that is in line with the default config & manifests we provide users)rate_intervaleverywhere [1]grr.jsonnetfile to the TNS mixin to allow easy deployment to hosted Grafana instances using Grizzlynamespacetemplate variable, as our default K8s integration config drops this metric[1] This is the only change that affects the non-
clouddeployment path