Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Basemaps URL and attributions #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Basemaps URL and attributions #280

wants to merge 1 commit into from

Conversation

skgsergio
Copy link

@skgsergio skgsergio commented Oct 1, 2020

Summary

This PR updates basemaps URL to the new CDN URL and fixes the attributions to match current requirements. It also changes our old name from CartoDB to CARTO (although looks that basemaps names are internal and not exposed to the user, we could skip this if has any kind of side-effects on existing basemaps and just change URL and Attributions).

Full context

We've recently changed our CDN (last week) and we have a plan mid-long term (depends on how quick we manage to stop all the traffic there) to deprecate our .global.ssl.fastly.net domains.

Reviewing the history of this project at some point it used the *.basemaps.cartocdn.com endpoints but were changed because of the lack of HTTPS, which is not an issue anymore.

Additional stuff

Just as a suggestion I'd add to the attributions <a> properties target="_blank" rel="noopener", this way if a user clicks on it doesn't close the Grafana dashboard but opens it in a new tab.

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Sergio Conde Gomez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@amotl
Copy link

amotl commented Oct 27, 2020

Dear Sergio,

may we humbly ask you to submit this PR to our grafana-map-panel fork? The vanilla Worldmap Panel has not been maintained for some time already. We would be happy to accept your contribution.

Just as a suggestion I'd add to the attributions <a> properties target="_blank" rel="noopener", this way if a user clicks on it doesn't close the Grafana dashboard but opens it in a new tab.

Sure, go ahead!

With kind regards,
Andreas.

@skgsergio
Copy link
Author

Thanks, @amotl will do it.

@amotl
Copy link

amotl commented Oct 27, 2020

Thanks for grafana-toolbox#74, Sergio! That was really quick.

@novohool
Copy link

Thanks, @amotl will do it.

Thanks for panodata#74, Sergio! That was really quick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants