Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make content in tooltip better visual experience. #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timoyan
Copy link

@timoyan timoyan commented Nov 16, 2020

Take different color in different theme (dark and light).

Current is really not very clear in light mode because font color and background color are too simliar.

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@timoyan
Copy link
Author

timoyan commented Nov 16, 2020

Btw, I try to run Run linter/prettier: npx grafana-toolkit plugin:dev according to https://github.com/panodata/grafana-map-panel/blob/develop/CONTRIBUTING.md
Found there is 9 places need to be fixed which not belongs to this pull request change, should I submit?

@amotl
Copy link

amotl commented Nov 16, 2020

Dear Timo,

thanks for your contribution. Our fork grafana-map-panel includes the improvement #191 by @dtheb (see also #169), amongst many others. See also #281.

With kind regards,
Andreas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants