Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add countries_names.json data mapping #322

Closed
wants to merge 1 commit into from
Closed

Add countries_names.json data mapping #322

wants to merge 1 commit into from

Conversation

daquinoaldo
Copy link

Add a mapping between countries' full names and their coordinates.
Needed for GCP integration: countries are exported with their full names, not their initials.

Add a mapping between countries' full names and their coordinates.
Needed for GCP integration: countries are exported with their full names, not their initials.
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2021

CLA assistant check
All committers have signed the CLA.

@amotl
Copy link

amotl commented Jul 27, 2021

Dear Aldo,

according to grafana-toolbox#108, the future of maps in Grafana will be the new Geomap panel, so your improvement should be directed to this implementation for Grafana >=8.1.

However, we will also be happy to receive a corresponding patch at our friendly fork https://github.com/panodata/panodata-map-panel. We will probably keep maintaining this for a while until Geomap will be stable and mature. In this manner, others who will also continue to use the vanilla Worldmap panel for a while, can benefit from your improvement.

With kind regards,
Andreas.

@daquinoaldo
Copy link
Author

Thank you, Andreas.
I'll open the same PR on the fork, and I'll explore the new panel as soon as the new version is released.

@amotl
Copy link

amotl commented Aug 6, 2021

Dear Aldo,

thanks a stack for submitting grafana-toolbox#117 the other day. I will try to have a look at this patch soonish.

With kind regards,
Andreas.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants