Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin.json : updated grafana dependency to >=8.0.0 #122

Merged
merged 2 commits into from
May 20, 2022
Merged

plugin.json : updated grafana dependency to >=8.0.0 #122

merged 2 commits into from
May 20, 2022

Conversation

yaelleC
Copy link
Contributor

@yaelleC yaelleC commented May 6, 2022

Part of https://github.com/grafana/cloud-data-sources/issues/9

We only want to support the two last major versions of Grafana, so we should update all our plugins so that they specify the minimum grafana version to be >=8.0.0. Releases of these plugins should be synced with grana 9.0.0 stable release (could be a few days after).

yaelleC
yaelleC commented May 6, 2022
View reviewed changes
src/plugin.json
@@ -34,8 +34,7 @@
"updated": "%TODAY%"
},
"dependencies": {
"grafanaVersion": "7.5.0",
Copy link
Contributor Author

@yaelleC yaelleC May 6, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafanaVersion is deprecated (https://grafana.com/docs/grafana/latest/developers/plugins/metadata/#properties-1 and https://grafana.com/docs/grafana/latest/developers/plugins/migration-guide/#update-the-pluginjson)

@github-actions
Copy link

github-actions bot commented May 6, 2022

Code coverage report for PR #122

Go TypeScript
main 69.8% 69.26%
PR 69.8% 69.26%
difference 0% 0%

@yaelleC yaelleC marked this pull request as ready for review May 11, 2022 10:24
@yaelleC yaelleC requested a review from a team as a code owner May 11, 2022 10:24
@yaelleC yaelleC requested review from asimpson and andresmgot and removed request for a team May 11, 2022 10:24
@yaelleC yaelleC merged commit 9ba725d into main May 20, 2022
@yaelleC yaelleC deleted the updateDep branch May 20, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yaelleC @asimpson @kevinwcyu