Update grafana-aws-sdk #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
requested review from
iwysiu and
kevinwcyu
and removed request for
a team
|
|
|
|
|
Backend code coverage report for PR #128 |
|
Frontend code coverage report for PR #128 |
iwysiu
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed the latest version of the grafana-aws-sdk (Both backend and frontend) to fix this authentication bug which I believe also happens here: grafana/athena-datasource#144
I ran go mod tidy which seems to have had other affects as well that I assume are ok? Maybe we should limit these dependencies to specific versions? Or maybe we are ok with them all auto updating? It seems to work ok for me