Filter on account id #157
Merged
Filter on account id #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor /accountIds to /accounts to be more future proof - make a for loop more readable - put work behind feature flag - move call to fetch account ids within QueryEditorForm - fix bug to reset selection, if account id is no longer a valid option - fix bug to handle edges with account ids with targets that do not have account ids - remove accidentally left comments.
Filter service graph by account id and add account id to autocomplete
|
|
Add some documentation for cross account queries
|
Backend code coverage report for PR #157
|
|
Frontend code coverage report for PR #157
|
fridgepoet
approved these changes
Nov 28, 2022
kevinwcyu
approved these changes
Nov 29, 2022
src/plugin.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "type": "datasource", | |||
| "name": "X-Ray", | |||
| "id": "grafana-x-ray-datasource", | |||
| "id": "grafana-x-ray-datasource-private-mirror", | |||
There was a problem hiding this comment.
ohh, thanks for finding this @kevinwcyu!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make it possible to filter service graph by account id and adds account id to autocomplete.
Fixes #156