Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare v2.4.0 release #172

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Prepare v2.4.0 release #172

merged 4 commits into from
Jan 26, 2023

Conversation

fridgepoet
Copy link
Member

Special notes:
It seems like the v2.3.0 tag was never created.
v2.2.0 was incorrectly named v2.3.0
I think we could either:

  • correct the changelog, make sure tag v2.2.0 includes the changes intended for v2.3.0
  • ignore this mishap and skip to v2.4.0

Any thoughts?

@github-actions
Copy link

Backend code coverage report for PR #172
No changes

@github-actions
Copy link

Frontend code coverage report for PR #172
No changes

@fridgepoet fridgepoet marked this pull request as ready for review January 25, 2023 17:09
@fridgepoet fridgepoet requested a review from a team as a code owner January 25, 2023 17:09
iwysiu
iwysiu approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like skipping to v2.4.0 would be less confusing? I don't love the idea of renaming things in the changelog

@fridgepoet fridgepoet merged commit a2a605b into main Jan 26, 2023
@fridgepoet fridgepoet deleted the release branch January 26, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwysiu iwysiu iwysiu approved these changes

@idastambuk idastambuk idastambuk approved these changes

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fridgepoet @iwysiu @idastambuk