Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed 2 broken links #180

Merged
merged 5 commits into from
Apr 10, 2023
Merged

fixed 2 broken links #180

merged 5 commits into from
Apr 10, 2023

Conversation

lwandz13
Copy link
Contributor

@lwandz13 lwandz13 commented Apr 6, 2023

Closes https://github.com/grafana/technical-documentation/issues/546

Fixed 2 links, one under alerting and the other regarding cross-account observability

Changed some wording for readability and clarity

@lwandz13 lwandz13 added the documentation Improvements or additions to documentation label Apr 6, 2023
@lwandz13 lwandz13 requested a review from chri2547 April 6, 2023 19:39
@lwandz13 lwandz13 requested a review from a team as a code owner April 6, 2023 19:39
@CLAassistant
Copy link

CLAassistant commented Apr 6, 2023

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Backend code coverage report for PR #180
No changes

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Frontend code coverage report for PR #180
No changes

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions.

lwandz13 and others added 4 commits April 7, 2023 07:55
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
Co-authored-by: Christopher Moyer <35463610+chri2547@users.noreply.github.com>
@lwandz13 lwandz13 enabled auto-merge (squash) April 10, 2023 14:27
@lwandz13 lwandz13 disabled auto-merge April 10, 2023 14:27
@fridgepoet fridgepoet self-requested a review April 10, 2023 14:47
@lwandz13 lwandz13 merged commit 661bcca into main Apr 10, 2023
1 check passed
@lwandz13 lwandz13 deleted the docs/update-xray-plugin branch April 10, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants