Fix array console output #1135
Merged
Fix array console output #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ka3de
reviewed
Dec 14, 2023
ankur22
force-pushed
the
add/remote-error
branch
from
f3e332c
to
3bcb2e2
Compare
ankur22
force-pushed
the
fix/array-console-output
branch
from
6aeed11
to
e522b1d
Compare
ankur22
force-pushed
the
add/remote-error
branch
2 times, most recently
from
82fb803
to
bda54b9
Compare
ankur22
dismissed stale reviews from ka3de and inancgumus
The base branch was changed.
ankur22
force-pushed
the
fix/array-console-output
branch
from
11be8b3
to
010b677
Compare
ankur22
force-pushed
the
fix/array-console-output
branch
from
010b677
to
a981764
Compare
This allows the remote object to be parsed into an array if that is what it is instead of an object where the keys are index values.
This updates parseConsoleRemoteObjectValue to work with parseConsoleRemoteArrayPreview which will parse an array.
Resolves: #1135 (comment)
ankur22
force-pushed
the
fix/array-console-output
branch
from
a981764
to
877cb03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This changes the way the output of an array with
console.outis parsed which affects the display from:to:
Why?
To better represent the array type when it is printed to the console.
Checklist
Related PR(s)/Issue(s)
Updates: #987