Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential nil exception when getting frame #1152

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Fix potential nil exception when getting frame #1152

merged 3 commits into from
Jan 11, 2024

Commits on Jan 10, 2024

  1. Fix potential nil exception when getting frame

    When a part of the browser module needs to retrieve the frame given an
    id, it should check whether the frame is nil before using it. This is
    not safe, since it's easy to forget to check for nil.
    
    This change avoids the need to check for nil and reinforces a
    requirement to check with an addition of a bool that is also returned
    to indicate whether the frame was found or not.
    ankur22 committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    d15ae71 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Apply suggestions from code review

    Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
    ankur22 and inancgumus committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    13b9e19 View commit details
    Browse the repository at this point in the history
  2. Refactor found to ok

    Ok is more idiomatic in Go.
    ankur22 committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    5bb8c60 View commit details
    Browse the repository at this point in the history