Fix potential nil exception when getting frame #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a part of the browser module needs to retrieve the frame given an id, it should check whether the frame is nil before using it. This is not safe, since it's easy to forget to check for nil. This change avoids the need to check for nil and reinforces a requirement to check with an addition of a bool that is also returned to indicate whether the frame was found or not.
ankur22
commented
Jan 10, 2024
ka3de
previously approved these changes
Jan 11, 2024
inancgumus
reviewed
Jan 11, 2024
Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
ankur22
force-pushed
the
fix/frame-npe
branch
from
04595b8
to
13b9e19
Compare
Ok is more idiomatic in Go.
inancgumus
approved these changes
Jan 11, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change avoids the need to check for
nilwhen getting the frame with an id, and reinforces a requirement to check with an addition of aboolreturn value to indicate whether the frame was found or not.Why?
When a part of the browser module needs to retrieve the frame given an id, it should check whether the frame is nil before using it. This is not safe, since it's easy to forget to check for nil, and so a new return value is also returned.
Checklist
Related PR(s)/Issue(s)
Updates: #1148