Add a localPersister #1197
Merged
Add a localPersister #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
refactor/use-local-persister
branch
4 times, most recently
from
4e032de
to
b3ebc26
Compare
ankur22
force-pushed
the
refactor/use-local-persister
branch
2 times, most recently
from
7377f20
to
7248c04
Compare
ankur22
force-pushed
the
refactor/use-local-persister
branch
3 times, most recently
from
6fdb869
to
ea3ff22
Compare
inancgumus
reviewed
Jan 30, 2024
ankur22
force-pushed
the
refactor/use-local-persister
branch
from
ea3ff22
to
c8d8cc7
Compare
ankur22
force-pushed
the
refactor/use-local-persister
branch
5 times, most recently
from
f161c6a
to
3cc7c51
Compare
inancgumus
reviewed
Jan 30, 2024
ankur22
commented
Jan 30, 2024
inancgumus
reviewed
Jan 30, 2024
ankur22
force-pushed
the
refactor/use-local-persister
branch
from
70cd67a
to
c2f30b9
Compare
This is the file persister that will be used when testing locally. This will replace the current implementation that is in screenshotter.
Adding a localPersister will allow access to it from anywhere that has access to the moduleVU. This change is a temporary refactor and will need to be changed again once the remotePersister has been implemented whereby either of the two will be chosen depending on the environment.
We're refactoring out the existing use of working directly with the os package to persist screenshots to the local disk from screenshotter. This change enables to work with the localPersister whereby the underlying details of the where and how are hidden allowing us to easily use either the localPersister (current) or the remotePersister (future).
This todo has been moved to the localPersister
ankur22
force-pushed
the
refactor/use-local-persister
branch
from
c2f30b9
to
ab79ae7
Compare
inancgumus
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change adds a new
LocalPersisterwhich will replace how thescreenshotterwrites to the local disk.Why?
This is the first step in removing the details of how and where the screenshot is being saved, allowing us to work with either a
LocalPersisteror (yet to be implemented)RemotePersister.Checklist
Related PR(s)/Issue(s)
Updates: #1155, #1156 and #1157.