Fix k6 Hosts option incompatibility #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We first update the k6 dependency (see go.mod and go.sum). Then we fix the breaking code. All tests pass. But, this solution is not an ideal one. As we are marshaling and unmarshaling to grab the hosts (see chromium/browser_type.go). Since the whole API has changed, I needed to fix tests with the new API as well. A proper solution would be to use the new API in our network code, instead of passing hosts to block to Chromium. PS: Sorry, I couldn't keep this PR shorter. The problem was CI would break if I sent each change as separate commits.
ankur22
approved these changes
Dec 8, 2022
| // TODO: A better way to do this would be to handle the resolver | ||
| // rules by communicating with Chromium (and then using Hosts's | ||
| // Match method) instead of passing the rules via the command line | ||
| // to Chromium. |
There was a problem hiding this comment.
How would we communicate with the chromium? CDP? I don't know why that would be better than passing the rules via the command line. Maybe we need another issue for that? 🙂
There was a problem hiding this comment.
Right. I'll create another issue next week. Let's get this issue out of the way since we're rushing 🏃 Reminder set 👍😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670.