Return an error from BrowserContext.SetExtraHTTPHeaders and handle panic in mapping layer #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the codebase uses panic too liberally and we don't have control over when we actually want to abort all test runs vs when we only want to fail the current test iteration.
The idea is that we will bubble up errors all the way to the mapping layer, where it can decide on whether to panic or to return an error to goja.
This would mean that we have more control over when to panic, and to be more aware of what we want to panic on, as well as using good GO error handling practices throughout the codebase.
This is the first PR that demonstrates how we can catch internal errors. There is another PR where we had most of the discussion and several other issues were found and resolved (#744). #744 was abandoned in favour of a new PR as the previous issue would require a lot of rework.
The script i've used to test this is:
The output of this when ran with this should be: