Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error from BrowserContext.SetExtraHTTPHeaders and handle panic in mapping layer #796

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Return an error from BrowserContext.SetExtraHTTPHeaders and handle panic in mapping layer #796

merged 2 commits into from
Feb 27, 2023

Commits on Feb 27, 2023

  1. Add an internal error to easily identify them 

    This internal error type will help us track internal errors so that
we can panic at the goja mapping layer instead of panicking from
within the business logic code.
    @ankur22
    ankur22 committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    2954828 View commit details
    Browse the repository at this point in the history

  2. Refactor addCookies to catch ErrInteral 

    This refactoring will catch ErrInternal errors and panic if found.
    @ankur22
    ankur22 committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    ee45317 View commit details
    Browse the repository at this point in the history