Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golangci/golangci-lint Docker tag to v1.55.0 #358

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 20, 2023

Mend Renovate

This PR contains the following updates:

Package Update Change
golangci/golangci-lint minor v1.54.2 -> v1.55.0

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

βœ… roobre
❌ renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@roobre roobre self-assigned this Oct 20, 2023
@renovate renovate bot force-pushed the renovate/golangci-golangci-lint-1.x branch from 009fde4 to 56118fa Compare October 23, 2023 13:31
.golangci.yml Outdated
Comment on lines 107 to 110
- goconst # Fails if the same strings used in several places but is not a constant. Not very useful.
- inamedparam # Fails if interfaces do not have named params. Not in our code style.
- perfsprint # Suggests using strconv.* instead of fmt.* for printing numbers. Not very practical.
- protogetter # Complains when code reads var.Something if var.GetSomething() exists. Not useful.
Copy link
Collaborator

@roobre roobre Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablochacin I'm proposing to disable these new linters as they do not seem very useful to me. LMK your thoughts about it, if you think they can be useful we can re-enable them and make the changes they suggest to the code.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roobre I think goconst may be useful as in general seems a sane convention (even if maybe we don't fully adhere to it). leave it up to you to decide.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reenabled goconst, it was not too hard to please it. I de-splitted some t.Errorf that were causing it to fire, and added a nolint directive to an iptables rule fragment we use quite a lot.

@renovate
Copy link
Contributor Author

renovate bot commented Oct 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@roobre roobre merged commit 792581e into main Oct 25, 2023
7 of 8 checks passed
@roobre roobre deleted the renovate/golangci-golangci-lint-1.x branch October 25, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants