Generic k8s interface #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
requested review from
javaducky and
dgzlopes
and removed request for
javaducky and
dgzlopes
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
dgzlopes
approved these changes
Sep 29, 2022
pkg/api/api.go
Outdated
| return err | ||
| } | ||
|
|
||
| // Create creates a resource in a kubernetes cluster from a yaml manifest |
There was a problem hiding this comment.
Suggested change
| // Create creates a resource in a kubernetes cluster from a yaml manifest | |
| // Create creates a resource in a Kubernetes cluster from a YAML manifest |
There was a problem hiding this comment.
The comment is actually wrong as this method does not receive a YAML but an object with the resource specification
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
dgzlopes
approved these changes
Sep 29, 2022
javaducky
approved these changes
Sep 29, 2022
|
|
||
| var pod = k8s.get(podSpec.kind, podSpec.metadata.name, podSpec.metadata.namespace) | ||
| if (podSpec.metadata.name != pod.metadata.name) { | ||
| throw new Error("Fetch by name did not return the Service. Expected: " + podSpec.metadata.name + " but got: " + fetched.name) |
There was a problem hiding this comment.
Super minor. Error message for the example refers to 'Service' instead of 'Pod'.
There was a problem hiding this comment.
Good catch. Fixed
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Generic interface for creating, retrieving, listing, deleting Kubernetes resources of any of a set of supported kinds such as Pod, Job, Secret, Service (among others)
Closes #68