Generate Batch without intermediate steps
#10
Comments
chaudum
added a commit
that referenced
this issue
Dec 1, 2021
This implementation is highly inefficient! It should be replaced when the intermediate step of creating entries (`[]Entry`) is removed (see issue #10). Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
added a commit
that referenced
this issue
Dec 1, 2021
This implementation is highly inefficient! It should be replaced when the intermediate step of creating entries (`[]Entry`) is removed (see issue #10). Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
added a commit
that referenced
this issue
Dec 1, 2021
This implementation is highly inefficient! It should be replaced when the intermediate step of creating entries (`[]Entry`) is removed (see issue #10). Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
mstoykov
added a commit
that referenced
this issue
Dec 2, 2021
mstoykov
added a commit
that referenced
this issue
Dec 2, 2021
mstoykov
added a commit
that referenced
this issue
Dec 2, 2021
mstoykov
added a commit
that referenced
this issue
Dec 3, 2021
Fixes #10 Basic benchmark results: old are the results with making entries and then batch, old- is only making the entries new is the new variant where we directly make the batch as can be seen there is around 50% reduction name \ time/op old.bench old-.bench new.bench GenerateEntries-8 255µs ± 9% 202µs ± 4% 138µs ± 5% name \ alloc/op old.bench old-.bench new.bench GenerateEntries-8 20.2kB ± 0% 12.5kB ± 0% 9.3kB ± 0% name \ allocs/op old.bench old-.bench new.bench GenerateEntries-8 435 ± 0% 213 ± 0% 216 ± 0% Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
added a commit
that referenced
this issue
Dec 3, 2021
Fixes #10 Basic benchmark results: old are the results with making entries and then batch, old- is only making the entries new is the new variant where we directly make the batch as can be seen there is around 50% reduction name \ time/op old.bench old-.bench new.bench GenerateEntries-8 255µs ± 9% 202µs ± 4% 138µs ± 5% name \ alloc/op old.bench old-.bench new.bench GenerateEntries-8 20.2kB ± 0% 12.5kB ± 0% 9.3kB ± 0% name \ allocs/op old.bench old-.bench new.bench GenerateEntries-8 435 ± 0% 213 ± 0% 216 ± 0% Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ATM, we generate a large slice of
Entryand then convert them into aBatch.To optimize allocations and CPU usage, generating the step could be done directly.
The text was updated successfully, but these errors were encountered: