Experimental Native Histogram #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
force-pushed
the
nativehistogram
branch
from
cce38fa
to
a70d836
Compare
codebien
force-pushed
the
nativehistogram
branch
2 times, most recently
from
0c0f15c
to
10e57f2
Compare
|
@olegbespalov I have rebased and addressed the request changes |
codebien
force-pushed
the
nativehistogram
branch
2 times, most recently
from
664496a
to
85a2b50
Compare
codebien
force-pushed
the
nativehistogram
branch
2 times, most recently
from
a0a8edb
to
b8b5d68
Compare
It requires the experimental Native Histogram feature enabled.
goos: linux goarch: amd64 pkg: github.com/grafana/xk6-output-prometheus-remote/pkg/remotewrite cpu: AMD Ryzen 7 4800H with Radeon Graphics BenchmarkK6TrendSinkAdd-16 92493090 13.25 ns/op BenchmarkHistogramSinkAdd-16 22255527 57.16 ns/op PASS ok github.com/grafana/xk6-output-prometheus-remote/pkg/remotewrite 4.167s
codebien
force-pushed
the
nativehistogram
branch
from
b8b5d68
to
7f7eee1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It adds an experimental mapping for Trend. It uses the new Prometheus' experimental feature Native Histogram.
A new
TrendAsNativeHistogramoption has been added for enabling it. If it is not explicitly enabled the Output continues to use the current AsGauges mapping.It also contains other changes not dedicated to this feature so they will be separated in the next few days with specific PRs:
Manual testing
The Docker compose has been updated so it can be used for testing. A new xk6 build based on this branch is required.
An example PromQL query for checking the generated data: