Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: library usage sample in readme #46

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

ryoshindo
Copy link
Contributor

Hello, grafana's engineering team!
I have used grafana, k6, etc. and they have been very helpful.

I fixed the library usage sample in the readme because it did not match the notation of the latest version.
Please check this page for any minor issues.

@CLAassistant
Copy link

CLAassistant commented Jun 29, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Thanks for this 🙇

This likely was partially left over from xcaddy and on this note can you also see my request to update one more place where we talk about module_path but it's actually a package_path

README.md Show resolved Hide resolved
@ryoshindo ryoshindo requested a review from mstoykov June 29, 2022 13:13
@mstoykov mstoykov merged commit 1ee61de into grafana:master Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants