Launch periodic task from a handler implemented #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSuprunenko
requested review from
mbg033,
EDDragonWolf,
cybay and
bitkis
AlexanderSuprunenko
force-pushed
the
feature/launch-periodic-task
branch
2 times, most recently
from
840d547
to
e688faa
Compare
bitkis
reviewed
Oct 25, 2018
| { | ||
| if(io_thread) | ||
| {//it is called from pre_action or post_action, and we can call requestAddPeriodicTask directly | ||
| addPeriodicTask({nullptr, h_worker, nullptr}, interval_ms, initial_interval_ms); |
There was a problem hiding this comment.
I'm lost a bit -- it seems a recursion, no?
There was a problem hiding this comment.
No. This addPeriodicTask takes Router::Handler& , addPeriodicTask that is called takes Router::Handler3&
bitkis
approved these changes
Nov 3, 2018
AlexanderSuprunenko
force-pushed
the
feature/launch-periodic-task
branch
from
e688faa
to
915285f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.