The State Machine implemented #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitkis
reviewed
Aug 21, 2018
| State state(State state) { return m_state = state; } | ||
| St status(BaseTaskPtr bt) const { return bt->getLastStatus(); } | ||
|
|
||
| void process(BaseTaskPtr bt) |
There was a problem hiding this comment.
Don't we need some logging here??
There was a problem hiding this comment.
Not sure. On one hand the messages would accompany others logging messages. On the other, they would be useful if we forgot to log such others, and they should be of special categorie, which we have no yet, to not overwhelm the log.
|
please make this PR vs. development/v0.0.2 |
AlexanderSuprunenko
changed the base branch from
development/v.0.0.1
to
development/v.0.0.2
cybay
reviewed
Aug 25, 2018
include/state_machine.h
Outdated
|
|
||
| for(auto& r : m_table) | ||
| { | ||
| if(m_state != std::get<0>(r)) continue; |
There was a problem hiding this comment.
Could we avoid these magic numbers? I mean all these get.
Enum wouldn't be more clear?
cybay
reviewed
Aug 25, 2018
| }; | ||
| } | ||
|
|
||
| const StateMachine::Guard StateMachine::hasnt(Router::Handler H3::* act) |
There was a problem hiding this comment.
Could it be just
return !has(act);
?
There was a problem hiding this comment.
No. A lambda is returned. ! for lambda has different meaning.
bitkis
approved these changes
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.