Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparseimage not deleted when using the --move option #297

Closed
andyincali opened this issue Oct 13, 2022 · 2 comments
Closed

Sparseimage not deleted when using the --move option #297

andyincali opened this issue Oct 13, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@andyincali
Copy link

The downloaded sparseimage is not deleted when using the --move option.

This seems to be because find_existing_installer is run before the download, and thus the $existing_sparseimage variable is empty when the rm is run as a part of move_to_applications_folder().

It should be possible to populate $existing_sparseimage by adding this just below the existing_installer stuff on line 1097:

existing_sparseimage=$( find "$workdir/"*.sparseimage -maxdepth 1 -type f -print -quit 2>/dev/null )

@andyincali andyincali added the bug Something isn't working label Oct 13, 2022
@grahampugh
Copy link
Owner

Ah, I understand the problem. existing_sparseimage only applies when the script is run and a sparseimage is found already. If the sparseimage is freshly downloaded and --move is invoked, we only have downloaded_sparseimage. Yeah, should be able to fix that.

grahampugh pushed a commit that referenced this issue Oct 14, 2022
@grahampugh
Copy link
Owner

Should hopefully be fixed in the latest v27.0 upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants